Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SSL ReloadWatcher to use java.time and java.nio #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor SSL ReloadWatcher to use java.time and java.nio #80

wants to merge 1 commit into from

Conversation

eperott
Copy link

@eperott eperott commented Mar 30, 2020

Closing TODO.

@eperott
Copy link
Author

eperott commented Mar 30, 2020

While refactoring this I considered to change the type of HttpServerOptions.sslServerKeyFile (and friends) to Path as well. However, as the Netty SslContextBuilder API is expecting the File type this became rather messy. And so I propose to leave those parts as is.

WDYT?

@johndelcastillo johndelcastillo force-pushed the master branch 2 times, most recently from 3b88272 to 84cb7cd Compare October 19, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eperott